Fix memory leak on Linux/Darwin platforms #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1572 +/- ##
==========================================
- Coverage 75.61% 74.87% -0.75%
==========================================
Files 15 15
Lines 808 816 +8
Branches 149 149
==========================================
Hits 611 611
- Misses 197 205 +8
Continue to review full report at Codecov.
|
|
I wish this fixed the issue for when the port goes out of scope but it's a great step in that direction. |
This was referenced Jun 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Poller should be deleted by WeakCallback (attached during wrapping), but v8 doc state : "There is no guarantee as to when or even if the callback is invoked" and indeed that never happens.
Changes consist code to allow deleting Poller object explicitly from JavaScript.